[riot-notifications] [RIOT-OS/RIOT] drivers/s*: add modules to Kconfig (#15717)

Francisco notifications at github.com
Thu Jan 21 09:24:03 CET 2021


@fjmolinas commented on this pull request.

Small comments, otherwise looks good, tested a couple of applications and there is no difference between binaries.



> @@ -0,0 +1,14 @@
+# Copyright (c) 2021 HAW Hamburg
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+config MODULE_SCD30

Since you already did this kind of cleanup for `si1133` do you mind removing the unneeded `ifneq (,$(filter scd30,$(USEMODULE)))` in the `Makefile.dep`? You can obviously dismiss

> +    select MODULE_SI70XX
+
+config MODULE_SI7021
+    bool "SI7021"
+    select MODULE_SI70XX
+
+endchoice
+
+config MODULE_SI70XX
+    bool
+    depends on HAS_PERIPH_I2C
+    select MODULE_PERIPH_I2C
+    select MODULE_XTIMER
+
+endif # TEST_KCONFIG
+

EOF

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15717#pullrequestreview-573062202
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210121/609848ca/attachment.htm>


More information about the notifications mailing list