[riot-notifications] [RIOT-OS/RIOT] sys/{crypto, hashes, random}: add modules to Kconfig (#15817)

Francisco notifications at github.com
Thu Jan 21 10:24:47 CET 2021


@fjmolinas commented on this pull request.

> Should we instead model the implementations as independent symbols and display/through and error when both are active?

Lets model as a choice for now, this can always be changed later if it seems like a more maintainable approach, but for now its the correct way of modeling IMO.

> @@ -0,0 +1,82 @@
+# Copyright (c) 2021 HAW Hamburg
+#
+# This file is subject to the terms and conditions of the GNU Lesser
+# General Public License v2.1. See the file LICENSE in the top level
+# directory for more details.
+#
+
+menuconfig MODULE_RANDOM
+    bool "Pseudo-Random Number Generation"
+    depends on TEST_KCONFIG
+    select MODULE_LUID
+    select MODULE_PERIPH_HWRNG if HAS_PERIPH_HWRNG && !MODULE_PUF_SRAM

>From what I can tell this preference is only modeled in the `auto_init` code right? I'm under the impression this dependency is incorrectly modeled in master though, from looking at the code its more like:

```
    select MODULE_LUID if HAS_PERIPH_CPUID
```

Also wouldn't this be better modeled with a choice?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15817#pullrequestreview-573094759
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210121/dee1f7b0/attachment.htm>


More information about the notifications mailing list