[riot-notifications] [RIOT-OS/RIOT] pkg/libfixmath: blacklist TOOLCHAIN=gnu for arm since division is off (#15828)

Alexandre Abadie notifications at github.com
Thu Jan 21 16:54:57 CET 2021

@aabadie commented on this pull request.

> @@ -6,3 +6,9 @@ ifneq (,$(filter libfixmath-unittests,$(USEMODULE)))
   # The round function is not provided by the msp430 toolchain
   FEATURES_BLACKLIST += arch_msp430
+ifneq (,$(filter arm%,$(CPU_ARCH)))

Not necessarily. If a different TOOLCHAIN is set from the command line, at this stage you know it already. And gcc the default toolchain anyway.

Some something like the following would work:

ifneq (llvm,$(TOOLCHAIN))
  FEATURES_BLACKLIST += arch_cortexm

I know it's a bit hacky but that the minimal change to skip the build on arm with gcc but not with llvm.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210121/28497396/attachment-0001.htm>

More information about the notifications mailing list