[riot-notifications] [RIOT-OS/RIOT] cpu/samd21: add support for SAMD20 & SAM D20 Xplained Pro board (#14662)

Marian Buschsieweke notifications at github.com
Thu Jan 21 17:47:19 CET 2021


@maribu commented on this pull request.

Looks good. Some comments inline

> +| MCU            | ATSAMD20J18A      |
+|:-------------- |:--------------------- |
+| Family         | ARM Cortex-M0+    |
+| Vendor         | Atmel |
+| RAM            | 32Kb |
+| Flash          | 256Kb             |
+| Frequency      | up to 48MHz |
+| FPU            | no                |
+| Timers         | 8 (16-bit)    |
+| ADCs           | 1x 12-bit (20 channels)           |
+| UARTs          | max 6 (shared with SPI and I2C)               |
+| SPIs           | max 6 (see UART)                  |
+| I2Cs           | max 6 (see UART)              |
+| Vcc            | 1.62V - 3.63V         |
+| Datasheet      | [Datasheet](http://ww1.microchip.com/downloads/en/DeviceDoc/SAM_D20_%20Family_Datasheet_DS60001504C.pdf) |
+| Board Manual   | [Board Manual](http://ww1.microchip.com/downloads/en/DeviceDoc/Atmel-42102-SAMD20-Xplained-Pro_User-Guide.pdf)|

```suggestion
| MCU            | ATSAMD20J18A      |
|:-------------- |:--------------------------------- |
| Family         | ARM Cortex-M0+                    |
| Vendor         | Atmel                             |
| RAM            | 32 KiB                            |
| Flash          | 256 KiB                           |
| Frequency      | up to 48MHz                       |
| FPU            | no                                |
| Timers         | 8 (16-bit)                        |
| ADCs           | 1x 12-bit (20 channels)           |
| UARTs          | max 6 (shared with SPI and I2C)   |
| SPIs           | max 6 (see UART)                  |
| I2Cs           | max 6 (see UART)                  |
| Vcc            | 1.62V - 3.63V                     |
| Datasheet      | [Datasheet](http://ww1.microchip.com/downloads/en/DeviceDoc/SAM_D20_%20Family_Datasheet_DS60001504C.pdf) |
| Board Manual   | [Board Manual](http://ww1.microchip.com/downloads/en/DeviceDoc/Atmel-42102-SAMD20-Xplained-Pro_User-Guide.pdf)|
```

> +| Device | PIN |
+|:------ |:--- |
+| LED0   | PA14 |
+| SW0 (button) | PA15 |

```suggestion
| Device        | PIN   |
|:------------- |:----- |
| LED0          | PA14  |
| SW0 (button)  | PA15  |
```

> +#ifdef REV_TCC
     while (tcc->SYNCBUSY.reg & (TCC_SYNCBUSY_CC0 << chan)) {}
+#endif

Doesn't this change behavior for non SAMD20 MCUs that do not decleare `REV_TCC`?

There previously `TC_SYNCBUSY_CC0 << chan` was checked instead of `TCC_SYNCBUSY_CC0 << chan` - now no synchronization is done.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14662#pullrequestreview-573511547
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210121/ba6fc28a/attachment-0001.htm>


More information about the notifications mailing list