[riot-notifications] [RIOT-OS/RIOT] cpu/samd21: add support for SAMD20 & SAM D20 Xplained Pro board (#14662)

benpicco notifications at github.com
Thu Jan 21 18:06:54 CET 2021


@benpicco commented on this pull request.



> +#ifdef REV_TCC
     while (tcc->SYNCBUSY.reg & (TCC_SYNCBUSY_CC0 << chan)) {}
+#endif

I must admit this is a bit hacky.
`_tcc_set()` can only called if TCC is present, this file relies heavily on compile-time evaluation of `_use_tcc()`/`_use_tc()` to avoid large `#ifdef` blocks.

I think there is a cleaner solution though.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/14662#discussion_r562048318
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210121/c26985ae/attachment.htm>


More information about the notifications mailing list