[riot-notifications] [RIOT-OS/RIOT] cpu/esp32: Add newline to emac_main debug prints (#15833)

Erik Ekman notifications at github.com
Thu Jan 21 21:06:44 CET 2021

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

The `DEBUG()` prints in cpu/esp32/vendor/esp-idf/ethernet/emac_main.c had no newlines included,
so the output was one big mess once debug is enabled. This fixes that by adding newlines.

### Testing procedure

Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

Change `ENABLE_DEBUG` to 1 in cpu/esp32/vendor/esp-idf/ethernet/emac_main.c and run
an app using ethernet (like `examples/paho-mqtt`) on a board that supports it.

Instead of printing
initializing ESP32 Ethernet MAC (EMAC) device
esp_eth_initesp_eth_init_internalemac_init_default_dataemac_set_user_config_dataemac_verify_argsemac_hw_initemac_init_dma_chainesp_eth_enableemac_ioctl sig=3 par=3ffb48b0emac_post sig=3 par=3ffb48b0emac_task sig=3 par=3ffb48b0emac_startemac start !!!
it will print
initializing ESP32 Ethernet MAC (EMAC) device
emac_ioctl sig=3 par=3ffb48b0
emac_post sig=3 par=3ffb48b0
emac_task sig=3 par=3ffb48b0
emac start !!!

### Issues/PRs references

Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.


You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * cpu/esp32: Add newline to emac_main debug prints

-- File Changes --

    M cpu/esp32/vendor/esp-idf/ethernet/emac_main.c (74)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210121/8b59516e/attachment-0001.htm>

More information about the notifications mailing list