[riot-notifications] [RIOT-OS/RIOT] pkg/openwsn/sock: fix sock_udp_close handling (#15838)

Francisco notifications at github.com
Fri Jan 22 17:08:45 CET 2021


@fjmolinas commented on this pull request.



> +    expect(0 == sock_udp_create(&_sock, &local, &remote, SOCK_FLAGS_REUSE_EP));
+    expect(_inject_packet(&src_addr, &dst_addr, _TEST_PORT_REMOTE,
+                            _TEST_PORT_LOCAL, test_data, sizeof(test_data),
+                            _TEST_NETIF));
+    sock_udp_close(&_sock);
+    expect(_check_net());

Should I add a comment:
```suggestion

    expect(0 == sock_udp_create(&_sock, &local, &remote, SOCK_FLAGS_REUSE_EP));
    /* inject a packet destined to _sock */
    expect(_inject_packet(&src_addr, &dst_addr, _TEST_PORT_REMOTE,
                            _TEST_PORT_LOCAL, test_data, sizeof(test_data),
                            _TEST_NETIF));
    /* _sock is closed before reading the packet, closing should drop it*/
    sock_udp_close(&_sock);
    expect(_check_net());
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15838#discussion_r562737296
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210122/174f4bab/attachment.htm>


More information about the notifications mailing list