[riot-notifications] [RIOT-OS/RIOT] sys/oneway-malloc: only allocate word-aligned chunks (#15844)
notifications at github.com
Sun Jan 24 15:33:45 CET 2021
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
If an unevenly sized allocation is requested, the next buffer handed out would start at an unaligned address.
Fix this by rounding up to the next word-sized allocation size.
### Testing procedure
Compile `tests/malloc` with
USEMODULE += oneway_malloc picolibc
CFLAGS += -DCHUNK_SIZE=129
(`oneway-malloc` is not compatible with newlib).
On `master` this will crash after the first allocation.
With this patch, allocations are performed as expected (and no deallocations)
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* sys/oneway-malloc: only allocate word-aligned chunks
-- File Changes --
M sys/oneway-malloc/oneway-malloc.c (10)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications