[riot-notifications] [RIOT-OS/RIOT] boards: add adafruit-itsybitsy-m4 (#15845)

Alexandre Abadie notifications at github.com
Sun Jan 24 18:04:30 CET 2021


@aabadie requested changes on this pull request.

Nice one. If you are able to have the stdio over USB working, then that will be of interest for me because I couldn't make it work on the adafruit edgebadge. I'll compare with my old branch.

> @@ -0,0 +1,16 @@
+CPU = samd5x
+CPU_MODEL = samd51g19a
+
+# Put defined MCU peripherals here (in alphabetical order)
+FEATURES_PROVIDED += highlevel_stdio
+FEATURES_PROVIDED += periph_dac
+FEATURES_PROVIDED += periph_eth

This is not part of the configured peripherals

> @@ -0,0 +1,6 @@
+CFLAGS += -DBOOTLOADER_UF2
+
+# Include all definitions for flashing with bossa other USB
+include $(RIOTBOARD)/common/samd21-arduino-bootloader/Makefile.include

If samd21-arduino-bootloader also works for samd51, maybe we should rename that module to something more generic (maybe sam0-arduino-bootloader but is samd51 really a sam0 ?)

> @@ -0,0 +1,2 @@
+source [find target/atsame5x.cfg]

Is there an access to a jtag or something so you can use openocd ?

>    BOSSA_ARDUINO_PREFLASH = yes
+  PREFLASH_DELAY ?= 2

Why do you need to set this value here ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15845#pullrequestreview-574949233
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210124/fbddf3f3/attachment.htm>


More information about the notifications mailing list