[riot-notifications] [RIOT-OS/RIOT] Makefile.include: change to account for TOOLCHAIN having dependencies (#15832)

Alexandre Abadie notifications at github.com
Mon Jan 25 18:55:36 CET 2021


@aabadie commented on this pull request.



> +# Use TOOLCHAIN environment variable to select the toolchain to use.
+# If native, TOOLCHAIN for OSX is llvm
+ifeq ($(BOARD),native)
+  ifeq ($(OS),Darwin)
+    TOOLCHAIN ?= llvm
+  endif
+endif
+# Use override so that we can redefine a variable set on the command line (as
+# opposed to one set in the environment)
+ifeq (clang,$(TOOLCHAIN))
+  # TOOLCHAIN = clang is an alias for TOOLCHAIN = llvm
+  override TOOLCHAIN := llvm
+endif
+ifeq (gcc,$(TOOLCHAIN))
+  # TOOLCHAIN = gcc is an alias for TOOLCHAIN = gnu
+  override TOOLCHAIN := gnu

Does this means that TOOLCHAIN is equal to `gnu` when Makefile.dep is processed ? If yes, the toolchain specific dependency file should be called `Makefile.gnu.dep` and not `Makefile.gcc.dep` (in  examples/gnrc_minimal) ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15832#pullrequestreview-575661091
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210125/baac14b8/attachment.htm>


More information about the notifications mailing list