[riot-notifications] [RIOT-OS/RIOT] tests/gnrc_ipv6_ext_frag: fetch Interface IDs dynamically (#15856)
notifications at github.com
Tue Jan 26 10:54:12 CET 2021
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Currently the test script for `tests/gnrc_ipv6_ext_frag` assumes a certain order and interface ID for the underlying application which provides one for a mocked transfer and one ethos interface to interact with the host-side scripting. However, ever since eb73515e2cfdf5e42c84dfd53489c0e63dc6f00b got merged (and probably others) got merged, that order and numbering is not true anymore, making the test fail at the moment.
This fixes the test to fetch the interface identifiers based on the Ethernet address of the interface (for ethos and assume the other to be the mock interface) and uses those identifiers throughout the script instead of the constant once.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
BOARD=samr21-xpro make -C tests/gnrc_ipv6_ext_frag/ -j flash
sudo BOARD=samr21-xpro make -C tests/gnrc_ipv6_ext_frag/ test
currently fails on master and in release branches `2020.10-branch` and `2021.01-branch`. With this fix, it will pass.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* tests/gnrc_ipv6_ext_frag: fetch Interface IDs dynamically
-- File Changes --
M tests/gnrc_ipv6_ext_frag/tests-as-root/01-run.py (85)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications