[riot-notifications] [RIOT-OS/RIOT] tests/gnrc_ipv6_ext_frag: fetch Interface IDs dynamically (#15856)

Alexandre Abadie notifications at github.com
Tue Jan 26 11:08:33 CET 2021


@aabadie commented on this pull request.



> +        if match:
+            # interface has a hardware address
+            ethos_id = int(child.match.group(1))
+            hwaddr = match.group(1)
+            # consume MTU for later calls of `ifconfig {mock_id}`
+            child.expect(r"MTU:(\d+)")
+        else:
+            mock_id = int(child.match.group(1))
+            # consume MTU for later calls of `ifconfig {mock_id}`
+            child.expect(r"MTU:(\d+)")

small improvement proposal:

```suggestion
        if match is not None:
            # interface has a hardware address
            ethos_id = int(child.match.group(1))
            hwaddr = match.group(1)
        else:
            mock_id = int(child.match.group(1))
        # consume MTU for later calls of `ifconfig {mock_id}`
        child.expect(r"MTU:(\d+)")
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15856#pullrequestreview-576198607
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210126/ddc5a88d/attachment.htm>


More information about the notifications mailing list