[riot-notifications] [RIOT-OS/RIOT] riotboot: implement serial flasher (#15493)

Francisco notifications at github.com
Tue Jan 26 16:35:21 CET 2021


@fjmolinas commented on this pull request.



> @@ -26,8 +26,8 @@ RAM_START_ADDR := $(shell printf "0x%08x" $$(($(RAM_BASE_ADDR)-($(KINETIS_SRAM_L
 # Define ROM_LEN with a non arithmetic value as it must be
 # evaluated in `cortexm_common` without a shell context
 # The `K` is correctly handled by both the linker and `cortexm_common`.
-ROM_LEN = $(KINETIS_ROMSIZE)K
-RAM_LEN = $$(($(KINETIS_RAMSIZE) * 1024))
+ROM_LEN := $(KINETIS_ROMSIZE)K

Add somwhere up:

```
ifneq (,$(filter riotboot_serial,$(USEMODULE)))
  RIOTBOOT_LEN ?= 0x2000
endif
```

Would need to be tested by the CI, but I think it needs to be 4k for most riotboot_serial compilations

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15493#pullrequestreview-576472518
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210126/8ef42cdc/attachment.htm>


More information about the notifications mailing list