[riot-notifications] [RIOT-OS/RIOT] pkg/libfixmath: blacklist TOOLCHAIN=gnu for arm since division is off (#15828)

Francisco notifications at github.com
Wed Jan 27 13:57:33 CET 2021


@fjmolinas commented on this pull request.



> @@ -6,3 +6,9 @@ ifneq (,$(filter libfixmath-unittests,$(USEMODULE)))
   # The round function is not provided by the msp430 toolchain
   FEATURES_BLACKLIST += arch_msp430
 endif
+
+ifneq (,$(filter gnu gcc,$(TOOLCHAIN)))

Initially, I had done as you suggested, but the unittest module only enable unittests to be run but the function is still there, and still, faulty whether the module is included o not (or at least that is what I expect)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15828#discussion_r565286309
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210127/9def4dd1/attachment.htm>


More information about the notifications mailing list