[riot-notifications] [RIOT-OS/RIOT] mtd: rename mtd_write_page() -> mtd_write_page_raw(), add high-level mtd_write_page() (#15843)

Marian Buschsieweke notifications at github.com
Thu Jan 28 08:54:51 CET 2021

@maribu approved this pull request.

ACK. Code looks good to me and I trust @dylad 's testing results.

If you want to go for a different module name (IMO matching the function is provides would be nice), squash right in.

> @@ -122,11 +134,49 @@ int mtd_write(mtd_dev_t *mtd, const void *src, uint32_t addr, uint32_t count)
     const uint32_t page_shift = bitarithm_msb(mtd->page_size);
     const uint32_t page_mask = mtd->page_size - 1;
-    return mtd_write_page(mtd, src, addr >> page_shift, addr & page_mask, count);
+    return mtd_write_page_raw(mtd, src, addr >> page_shift, addr & page_mask, count);

Maybe rename the module, now that the function has been renamed?

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210127/0a638538/attachment.htm>

More information about the notifications mailing list