[riot-notifications] [RIOT-OS/RIOT] cpu/nrf5x: enhance external HF clock source handling to allow for substantial energy savings (#15804)

Hauke Petersen notifications at github.com
Fri Jan 29 09:27:38 CET 2021

@haukepetersen commented on this pull request.

> @@ -446,7 +459,7 @@ int nrf802154_init(void)
     /* power off peripheral */
-    NRF_RADIO->POWER = 0;
+    _power_off();

Thats bad, it means that the driver in its current form can break the power management for third party modules... Example: 
- some other module explicitly requests the HFXO
- this drivers init is called -> the HFXO is disabled
- the other module will not function as expected as it depends on HFXO

Bottom line: we need to make sure that each driver/module requesting the HFXO is always keeping the HFXO in a consistent state. So in case there are user API functions that can alter the HFXO state and can be called any time (e.g. `nrf802154_ops->off`), the driver needs to keep its own state for the HFXO.

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210129/fb81522f/attachment.htm>

More information about the notifications mailing list