[riot-notifications] [RIOT-OS/RIOT] cpu/nrf5x: enhance external HF clock source handling to allow for substantial energy savings (#15804)

Hauke Petersen notifications at github.com
Fri Jan 29 09:29:35 CET 2021


@haukepetersen commented on this pull request.



> +    --_hfxo_requests;
+    if (_hfxo_requests == 0) {

I don't like this at all, as it hides inconsistent state in other modules/drivers and thus potentially leads to pretty ugly latent failures (see comment above)... 

However putting an assertion for `assert(_hfxo_requests);` in here would certainly not hurt!

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15804#discussion_r566653884
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210129/2051d6c8/attachment.htm>


More information about the notifications mailing list