[riot-notifications] [RIOT-OS/RIOT] boards/atmega: cleanup BOOTLOADER variables definitions (#15887)
notifications at github.com
Fri Jan 29 15:42:44 CET 2021
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
This PR is a cleanup of the BOOTLOADER/BOOTLOADER_SIZE/BOOTLOADER_BAUD variable used on some atmega platform.
It remove the IMHO useless pattern:
BOOTLOADER_<board name> ?= bootloader
BOOTLOADER ?= $(BOOTLOADER_<board name>)
And add an `ATMEGA_` to all these atmega specific variables (only used in boards/common/atmega).
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
Try to flash the affected boards (but should be harmless).
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Noticed that while reviewing #15884
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* boards/atmega: cleanup BOOTLOADER variables definitions
-- File Changes --
M boards/arduino-duemilanove/Makefile.include (3)
M boards/arduino-leonardo/Makefile.include (2)
M boards/arduino-mega2560/Makefile.include (3)
M boards/arduino-nano/Makefile.include (3)
M boards/arduino-nano/doc.txt (4)
M boards/arduino-uno/Makefile.include (3)
M boards/avr-rss2/Makefile.include (5)
M boards/common/atmega/Makefile.include (36)
M boards/derfmega128/Makefile.include (2)
M boards/derfmega256/Makefile.include (2)
M boards/mega-xplained/Makefile.include (2)
M boards/microduino-corerf/Makefile.include (3)
M boards/waspmote-pro/Makefile.include (3)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications