[riot-notifications] [RIOT-OS/RIOT] cpu/qn908x: Implement blocking SPI support (#15689)

benpicco notifications at github.com
Sat Jan 30 20:25:28 CET 2021


@benpicco commented on this pull request.



> +        .copi_pin       = GPIO_PIN(PORT_A, 4),
+        .cipo_pin       = GPIO_PIN(PORT_A, 5),

```suggestion
        .cipo_pin       = GPIO_PIN(PORT_A, 5),
        .copi_pin       = GPIO_PIN(PORT_A, 4),
```

In C++, fields must be initialized in the same order as they are declared.
This should fix the build failure with `tests/cpp11_mutex`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15689#pullrequestreview-579799074
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210130/596138e8/attachment-0001.htm>


More information about the notifications mailing list