[riot-notifications] [RIOT-OS/RIOT] cpu/qn908x: Implement blocking SPI support (#15689)

Marian Buschsieweke notifications at github.com
Sat Jan 30 21:10:58 CET 2021


@maribu commented on this pull request.



> +        .copi_pin       = GPIO_PIN(PORT_A, 4),
+        .cipo_pin       = GPIO_PIN(PORT_A, 5),

How about adding `-Wno-missing-field-initializers` to `CXXFLAGS` instead? IMO the whole point in using member names during the initialization is to future proof your code, so that reordering members or adding members to a `struct` won't fall on your foot.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15689#discussion_r567308989
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210130/a5b91aa0/attachment.htm>


More information about the notifications mailing list