[riot-notifications] [RIOT-OS/RIOT] Introduce ATxmega CPU and Boards (#15758)

Gerson Fernando Budke notifications at github.com
Sun Jan 31 15:47:53 CET 2021


@nandojve commented on this pull request.



> +#include "cpu_clock.h"
+#include "cpu.h"
+#include "irq.h"
+#include "periph/gpio.h"
+#include "periph/init.h"
+
+#ifndef CPU_ATXMEGA_CLK_SCALE_INIT
+#define CPU_ATXMEGA_CLK_SCALE_INIT    CPU_ATXMEGA_CLK_SCALE_DIV1
+#endif
+#ifndef CPU_ATXMEGA_BUS_SCALE_INIT
+#define CPU_ATXMEGA_BUS_SCALE_INIT    CPU_ATXMEGA_BUS_SCALE_DIV1_1
+#endif
+
+void led_init(void);
+
+void clk_init(void)

The cpu_init is in cpu/avr8_common and shared between atmega and atxmega variants.
Any changes here can result in an structural re-work for megas. It will be good to me understand what could be the better move. I don't see problems to move xmega clock_init to cpu/atxmega. I've been thinking to change it to weak to allow board tune.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15758#discussion_r567436597
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210131/e1887eda/attachment-0001.htm>


More information about the notifications mailing list