[riot-notifications] [RIOT-OS/RIOT] drivers/sx126x: Add support for Nucleo -WL55JC (#16579)

José Alamos notifications at github.com
Thu Jul 1 10:32:10 CEST 2021


@jia200x commented on this pull request.



> @@ -30,6 +30,10 @@
 #include "sx126x.h"
 #include "sx126x_netdev.h"
 
+#if IS_USED(MODULE_SX126X_PERIPH)
+#include "board.h"

why do we need a board dependency from the driver? this seems weird

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16579#pullrequestreview-696969642
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210701/9dc215d8/attachment.htm>


More information about the notifications mailing list