[riot-notifications] [RIOT-OS/RIOT] drivers/sx126x: Add support for Nucleo -WL55JC (#16579)

MrKevinWeiss notifications at github.com
Thu Jul 1 10:45:25 CEST 2021


@MrKevinWeiss commented on this pull request.



> +#if IS_USED(MODULE_SX126X_PERIPH)
+#ifndef CONFIG_SX126X_CAL_DEFAULT
+#define CONFIG_SX126X_CAL_DEFAULT               (0x7F)
+#endif
+
+#define REG_XTA_TRIM                            0x0911
+#endif
+

This should actually be part of the driver param as each device may need a different setting.

This param should be declared in the board as it is based on capacitor values.

If it works fine with untouched values maybe leave it out of this PR and if needed it can be added later.

>      /* Reset the device */
     sx126x_reset(dev);
 
+#if IS_USED(MODULE_SX126X_PERIPH)
+    sx126x_set_standby(dev, SX126X_STANDBY_CFG_RC);
+    sx126x_set_dio3_as_tcxo_ctrl(dev, SX126X_TCXO_CTRL_1_7V, 10 << 6 );
+    sx126x_write_register(dev, REG_XTA_TRIM, ( const uint8_t[] ){ 0x00 },1);
+    sx126x_cal(dev, CONFIG_SX126X_CAL_DEFAULT);

This should also be removed but again, first check that the performance is unaffected.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16579#pullrequestreview-696981110
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210701/ce3eec56/attachment.htm>


More information about the notifications mailing list