[riot-notifications] [RIOT-OS/RIOT] drivers/sx126x: Add support for Nucleo -WL55JC (#16579)

Leandro Lanzieri notifications at github.com
Mon Jul 5 19:49:27 CEST 2021


@leandrolanzieri commented on this pull request.



> + *
+ * @file        board.c
+ * @brief       Board specific implementations for the Nucleo-wl55jc board
+ *
+ *
+ * @author      Akshai M <akshai.m at fu-berlin.de>
+ *
+ * @}
+ */
+
+#include <stdio.h>
+
+#include "board.h"
+#include "periph/gpio.h"
+
+#include "sx126x.h"

I think this and the driver-related function should be guarded, otherwise the package header file is missing when not included.

> +menuconfig KCONFIG_USEMODULE_CPU_FAM_STM32WL_DEBUG
+    bool "STM2WL Debugging"
+    depends on CPU_MODEL_STM32WL55JC
+
+if KCONFIG_USEMODULE_CPU_FAM_STM32WL_DEBUG

Following the style of the existing Kconfig files for STM32, this `menuconfig` can be avoided, just keep the configuration option.

> @@ -0,0 +1,21 @@
+# Copyright (c) 2021 Freie Universitaet Berlin

This would fit better either on in the `kconfigs` directory or as part of an existing Kconfig file there. 

> +    bool "SX1268"
+    select MODULE_SX126X
+    select MODULE_PERIPH_GPIO
+    select MODULE_PERIPH_GPIO_IRQ
+
+config MODULE_LLCC68
+    bool "LLCC68"
+    select MODULE_SX126X
+    select MODULE_PERIPH_GPIO
+    select MODULE_PERIPH_GPIO_IRQ
+
+config MODULE_SX126X_STM32WL
+    bool "SX126X-STM32WL"
+    select MODULE_SX126X
+    select MODULE_PERIPH_GPIO
+    select MODULE_PERIPH_GPIO_IRQ

Does it depend on GPIO IRQ?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16579#pullrequestreview-699352341
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210705/e4c9f055/attachment.htm>


More information about the notifications mailing list