[riot-notifications] [RIOT-OS/RIOT] drivers/sx126x: Add support for Nucleo -WL55JC (#16579)

Francisco notifications at github.com
Wed Jul 7 15:32:42 CEST 2021


@fjmolinas commented on this pull request.



> +        .dev      = SUBGHZSPI, /* Internally connected to Sub-GHz radio Modem  */
+        .rccmask  = RCC_APB3ENR_SUBGHZSPIEN,
+        .apbbus   = APB3,
+    }

@akshaim Murdock is complaining that fielsd are unitialized:

```
../../boards/nucleo-wl55jc/include/periph_conf.h:107:1: error: missing initializer for member 'spi_conf_t::miso_pin' [-Werror=missing-field-initializers]
../../boards/nucleo-wl55jc/include/periph_conf.h:107:1: error: missing initializer for member 'spi_conf_t::sclk_pin' [-Werror=missing-field-initializers]
../../boards/nucleo-wl55jc/include/periph_conf.h:107:1: error: missing initializer for member 'spi_conf_t::cs_pin' [-Werror=missing-field-initializers]
../../boards/nucleo-wl55jc/include/periph_conf.h:107:1: error: missing initializer for member 'spi_conf_t::mosi_af' [-Werror=missing-field-initializers]
../../boards/nucleo-wl55jc/include/periph_conf.h:107:1: error: missing initializer for member 'spi_conf_t::miso_af' [-Werror=missing-field-initializers]
../../boards/nucleo-wl55jc/include/periph_conf.h:107:1: error: missing initializer for member 'spi_conf_t::sclk_af' [-Werror=missing-field-initializers]
../../boards/nucleo-wl55jc/include/periph_conf.h:107:1: error: missing initializer for member 'spi_conf_t::cs_af' [-Werror=missing-field-initializers]
```

```suggestion
        .dev      = SUBGHZSPI, /* Internally connected to Sub-GHz radio Modem  */
        .rccmask  = RCC_APB3ENR_SUBGHZSPIEN,
        .apbbus   = APB3,
    }
```

Use `GPIO_UNDEF` for the GPIO's,, maybe it makes sense to add a `GPIO_AF_UNDEF` to `gpio_af_t` for this platform. @jia200x do you have another idea?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16579#pullrequestreview-701011073
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210707/64c6e45e/attachment.htm>


More information about the notifications mailing list