[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: include RIO after configuring downstream subnets (#16590)

Martine Lenders notifications at github.com
Thu Jul 8 09:13:38 CEST 2021


@miri64 commented on this pull request.



> -    /* Disable router advertisements on upstream interface. With this, the border
-     * router
-     * 1. Does not confuse the upstream router to add the border router to its
-     *    default router list and
-     * 2. Solicits upstream Router Advertisements quicker to auto-configure its
-     *    upstream global address.
-     */

Also: this comment still disappears.

> @@ -174,6 +174,17 @@ void dhcpv6_client_conf_prefix(unsigned iface, const ipv6_addr_t *pfx,
             gnrc_rpl_root_init(CONFIG_GNRC_RPL_DEFAULT_INSTANCE, &addr, false, false);
         }
     }
+
+    /* start advertising subnet obtained via DHCPv6 */
+    gnrc_ipv6_nib_change_rtr_adv_iface(netif, true);

Same here, why make this a general thing and not config-specific?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16590#pullrequestreview-701713540
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210708/2068640d/attachment-0001.htm>


More information about the notifications mailing list