[riot-notifications] [RIOT-OS/RIOT] drivers/sx126x: Add support for Nucleo -WL55JC (#16579)

Francisco notifications at github.com
Thu Jul 8 10:23:05 CEST 2021


@fjmolinas commented on this pull request.



> +        .dev      = SUBGHZSPI, /* Internally connected to Sub-GHz radio Modem  */
+        .rccmask  = RCC_APB3ENR_SUBGHZSPIEN,
+        .apbbus   = APB3,
+    }

> I just pushed the changes and a check for valid gpio in spi ( #16625 ). If GPIO is not used then `GPIO_AF_UNDEF ` would not really make a difference right?

It wouldn't for initialization but I think its cleaner, can you apply this patch:

```diff
diff --git a/cpu/stm32/include/periph_cpu.h b/cpu/stm32/include/periph_cpu.h
index a3caf8be85..2936dcdc1c 100644
--- a/cpu/stm32/include/periph_cpu.h
+++ b/cpu/stm32/include/periph_cpu.h
@@ -326,6 +326,8 @@ typedef enum {
     GPIO_AF14,              /**< use alternate function 14 */
     GPIO_AF15               /**< use alternate function 15 */
 #endif
+    GPIO_AF_UNDEF,          /** an UNDEF value definition, e.g. for register
+                                based spi */
 #endif
 } gpio_af_t;
 ```
 
 You can include it in this PR IMO but in a separate commit, `git commit -m "cpu/stm32: add GPUI_AF_UNDEF"`, and then use the definition to initialize those fields plese.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16579#discussion_r665977761
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210708/d92fc969/attachment.htm>


More information about the notifications mailing list