[riot-notifications] [RIOT-OS/RIOT] cpu/rpx0xx: port RIOT to the Raspberry Pi RP2040 MCU (#16609)

Marian Buschsieweke notifications at github.com
Thu Jul 8 11:53:13 CEST 2021


@maribu commented on this pull request.



> +    }
+    io_reg_atomic_set(&dev->UARTCR.reg, enable_mask);
+    uart_init_pins(uart);
+
+    _irq_enable(uart);
+
+    return UART_OK;
+}
+
+void uart_write(uart_t uart, const uint8_t *data, size_t len)
+{
+    UART0_Type *dev = uart_config[uart].dev;
+
+    for (size_t i = 0; i < len; i++) {
+        dev->UARTDR.reg = data[i];
+        mutex_lock(&tx_locks[uart]);

The FIFO is not used by the driver. It would have to busy wait until the char is send.

IMO we really should just disallow using UART during IRQ. We do so for every other periph, I don't know why UART is special in this regard.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16609#discussion_r666045514
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210708/462b46b0/attachment.htm>


More information about the notifications mailing list