[riot-notifications] [RIOT-OS/RIOT] gnrc_tcp: refactor tests (#16461)

Simon Brummer notifications at github.com
Thu Jul 8 16:08:59 CEST 2021


> 
> 
> > It adds a few python helper classes simplifying the process of writing tests.
> 
> How would you feel about porting the tests to [`riotctrl`](https://github.com/RIOT-OS/riotctrl/) instead? That is the "new" way for implementing tests. Some of the commands implemented by `shell_commands` are provided in [`riotctrl_shell`](https://github.com/RIOT-OS/RIOT/tree/master/dist/pythonlibs/riotctrl_shell), application-specific `ShellInteraction`s usually are implemented within the applications python test part (basically where you have the helpers now).

Makes sence from my point of view. Although this PR and the two PR building onto of this PR introduce new tests based on the old scheme. I would prefer the we review and merge the open followup PRs and port the tests in a single PR after the successfull sock integration. @miri64 What do you think about this approach?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16461#issuecomment-876471574
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210708/55f9a39b/attachment.htm>


More information about the notifications mailing list