[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: include RIO after configuring downstream subnets (#16590)

Leandro Lanzieri notifications at github.com
Fri Jul 9 09:12:04 CEST 2021


@leandrolanzieri commented on this pull request.



> @@ -57,6 +57,7 @@ endif
 
 ifneq (,$(filter gnrc_dhcpv6_client_simple_pd,$(USEMODULE)))
   USEMODULE += gnrc_dhcpv6_client
+  CFLAGS += -DCONFIG_GNRC_IPV6_NIB_ADV_ROUTER=0

As I understand this line, when `gnrc_dhcpv6_client_simple_pd` module is on, the router advertising should be off. right? Then this would translate into adding a dependency to the option:
```
config GNRC_IPV6_NIB_ADV_ROUTER
    bool "Activate router advertising at interface start-up"
    default y if GNRC_IPV6_NIB_ROUTER && (!GNRC_IPV6_NIB_6LR || GNRC_IPV6_NIB_6LBR)
    depends on !USEMODULE_GNRC_DHCPV6_CLIENT_SIMPLE_PD
```

If it is a default value instead, it should be decided the priority vs. the existing one and added as `default n if USEMODULE_GNRC_DHCPV6_CLIENT_SIMPLE_PD`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16590#discussion_r666724242
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210709/943248ab/attachment.htm>


More information about the notifications mailing list