[riot-notifications] [RIOT-OS/RIOT] sys/net/dhcpv6: include RIO after configuring downstream subnets (#16590)

Leandro Lanzieri notifications at github.com
Fri Jul 9 12:57:34 CEST 2021


@leandrolanzieri commented on this pull request.



> @@ -57,6 +57,7 @@ endif
 
 ifneq (,$(filter gnrc_dhcpv6_client_simple_pd,$(USEMODULE)))
   USEMODULE += gnrc_dhcpv6_client
+  CFLAGS += -DCONFIG_GNRC_IPV6_NIB_ADV_ROUTER=0

Defaults are evaluated from top to bottom, and the first one that matches the condition is applied. If this new condition does not take precedence to the existing one then it looks good to me.

A note though: as the default is `n`, which is the normal default for `bool`, it may be avoided, but it does not hurt to make it explicit in case another default is included in the future.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16590#discussion_r666863087
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210709/cf00ff22/attachment.htm>


More information about the notifications mailing list