[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)

José Alamos notifications at github.com
Mon Jul 12 18:00:16 CEST 2021


@jia200x commented on this pull request.



> +    if ((adr == true) && (mac->mlme.adr == false)) {
+        mac->mlme.adr_ack_cnt = 0;
+    }
     mac->mlme.adr = adr;

```suggestion
    if (mac->mlme.adr == adr) {
        return -EALREADY;
    }
    mac->mlme.adr = adr;
    mac ->mlme.adr_ack_cnt = 0;
```

It doesn't hurt to set it to 0 again and probably saves some ROM.
This would mean the function should be `int` and the upper layer should take care of the error code (as we usually do with NETOPTS)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15995#pullrequestreview-704285587
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210712/44067f52/attachment.htm>


More information about the notifications mailing list