[riot-notifications] [RIOT-OS/RIOT] makefiles/kconfig.mk: force SHOULD_USE_KCONFIG if config file is present (#16641)

José Alamos notifications at github.com
Wed Jul 14 01:17:48 CEST 2021

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
This PR forces SHOULD_RUN_KCONFIG whenever a previous configuration file is present.
As it is on master, running `make menuconfig` on applications that set `SHOULD_RUN_KCONFIG` to blank (e.g `gnrc_lorawan`) will silently fail because the keys are not set.

It's fine to skip calling Kconfig if an `app.config` file is set and `SHOULD_RUN_KCONFIG` not, but if the user explicitly called `make menuconfig` Kconfig should not be skipped.

This commit also adds a warning when the config file is present and `SHOULD_RUN_KCONFIG` is not.

Thanks @leandrolanzieri for the proposed fix!

Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
make clean
# Should not show any warning
make menuconfig
# Save menuconfig
# Now it should show a warning and set SHOULD_RUN_KCONFIG to 1.
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references

None so far
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * makefiles/kconfig.mk: force SHOULD_USE_KCONFIG if config file is present

-- File Changes --

    M makefiles/kconfig.mk (20)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210713/cdc4af04/attachment.htm>

More information about the notifications mailing list