[riot-notifications] [RIOT-OS/RIOT] gnrc_sock: imply end-point netif only if unset [backport 2021.07] (#16647)
notifications at github.com
Wed Jul 14 14:18:30 CEST 2021
# Backport of #16643
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
### Contribution description
Found this while testing https://github.com/RIOT-OS/RIOT/pull/16606: When using the `gnrc_netif_single` optimization module `gnrc_sock` basically accepts any `netif` value in the `gnrc_sock*_ep_t` structs, as it is just overwritten with the ID only existing network interface. While this seems like a nice extra from a shell user perspective, I wouldn't call this behavior valid and it also might cause some faulty behavior if e.g. invalid interface IDs are received from the network (as might be the case with DHCPv6's [Interface ID option]() https://github.com/RIOT-OS/RIOT/pull/16606).
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
### Testing procedure
The following tests should still pass:
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
### Issues/PRs references
Examples: Fixes #1234. See also #5678. Depends on PR #9876.
Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
You can view, comment on, or merge this pull request online at:
-- Commit Summary --
* gnrc_sock: imply end-point netif only if unset
-- File Changes --
M sys/net/gnrc/sock/include/gnrc_sock_internal.h (2)
-- Patch Links --
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications