[riot-notifications] [RIOT-OS/RIOT] net/lorawan: Revert #16604 and fix NETOPT_RX_SYMBOL_TIMEOUT documentation [backport 2021.07] (#16648)

José Alamos notifications at github.com
Wed Jul 14 15:04:39 CEST 2021

The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.

### Contribution description
Backport of #16640 .

This backport is not a copy of #16440:
- There's no support for NETOPT_RX_SYMBOL_TIMEOUT for the sx126x in the 2021.07 release branch. That feature was merged after feature freeze.
- #16577 was merged after HFF. Therefore https://github.com/RIOT-OS/RIOT/commit/50c0002540aa9f65aef812d38ddb4004322a80c8 was adapted accordingly.
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes

### Testing procedure
Same as #16640 .
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output

### Issues/PRs references
#16640 .
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.

You can view, comment on, or merge this pull request online at:


-- Commit Summary --

  * Revert "tests/driver_sx127x: use uint8_t for NETOPT_RX_SYMBOL_TIMEOUT"
  * Revert "net/gnrc_lorawan: use uint8_t for NETOPT_RX_SYMBOL_TIMEOUT"
  * Revert "pkg/semtech-loramac: use uint8_t for NETOPT_RX_SYMBOL_TIMEOUT"
  * Revert "drivers/sx127x: fix size of rx symbol timeout"
  * netopt: fix NETOPT_RX_SYMBOL_TIMEOUT documentation

-- File Changes --

    M drivers/include/sx127x.h (2)
    M drivers/sx127x/sx127x_getset.c (6)
    M drivers/sx127x/sx127x_netdev.c (4)
    M pkg/semtech-loramac/contrib/semtech_loramac_radio.c (5)
    M sys/include/net/netopt.h (2)
    M sys/net/gnrc/link_layer/lorawan/gnrc_lorawan.c (2)
    M tests/driver_sx127x/main.c (2)

-- Patch Links --


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210714/db85a583/attachment.htm>

More information about the notifications mailing list