[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)

José Alamos notifications at github.com
Wed Jul 14 16:32:36 CEST 2021


@jia200x commented on this pull request.



> +    if (mac->mlme.adr_ack_cnt  > (CONFIG_LORAMAC_DEFAULT_ADR_ACK_LIMIT +
+         CONFIG_LORAMAC_DEFAULT_ADR_ACK_DELAY)) {
+             if (mac->last_dr) {
+                DEBUG("gnrc_lorawan_mcps: ADRACKReq: Decrement DR\n");
+                mac->last_dr--;
+             }
+    }

This snippet is still wrong...
as it is, it decreases the DR anytime there's no RX and the `adr_ack_cnt` is greater than `CONFIG_LORAMAC_DEFAULT_ADR_ACK_LIMIT` + `CONFIG_LORAMAC_DEFAULT_ADR_ACK_DELAY`.

This pattern was already proposed in https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r583743697. Is there anything wrong with that?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15995#pullrequestreview-706350929
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210714/037fff9f/attachment.htm>


More information about the notifications mailing list