[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)
notifications at github.com
Wed Jul 14 16:34:48 CEST 2021
@jia200x commented on this pull request.
> + case MIB_ADR:
+ mlme_confirm->status = GNRC_LORAWAN_REQ_STATUS_SUCCESS;
+ gnrc_lorawan_set_adr(mac, mlme_request->mib.adr);
This should have a `get` counterpart. Also, I think it would be better to make `gnrc_lorawan_set_adr` a function and return error codes accordingly (e.g `-EALREADY`)
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
More information about the notifications