[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)

José Alamos notifications at github.com
Wed Jul 14 16:34:48 CEST 2021


@jia200x commented on this pull request.



> +        case MIB_ADR:
+            mlme_confirm->status = GNRC_LORAWAN_REQ_STATUS_SUCCESS;
+            gnrc_lorawan_set_adr(mac, mlme_request->mib.adr);
+            break;

This should have a `get` counterpart. Also, I think it would be better to make `gnrc_lorawan_set_adr` a function and return error codes accordingly (e.g `-EALREADY`)

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15995#pullrequestreview-706353620
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210714/2b4f4374/attachment.htm>


More information about the notifications mailing list