[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)

José Alamos notifications at github.com
Fri Jul 16 12:40:06 CEST 2021


@jia200x commented on this pull request.



> @@ -254,6 +254,17 @@ void gnrc_lorawan_generate_session_keys(const uint8_t *app_nonce,
  */
 int gnrc_lorawan_set_dr(gnrc_lorawan_t *mac, uint8_t datarate);
 
+/**
+ * @brief Set TX power (PHY parameter) for the next transmission
+ *
+ * @param[in] mac pointer to the MAC descriptor
+ * @param[in] tx_pwr desired TX power index
+ *
+ * @return 0 on success
+ * @return -EINVAL if TX power is not available in the current region

You should add another return with "@return negative errno". Since there's a call to `dev->driver->set` there could be other return codes as well

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15995#pullrequestreview-708238061
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210716/009123be/attachment.htm>


More information about the notifications mailing list