[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)

José Alamos notifications at github.com
Fri Jul 16 12:58:05 CEST 2021


@jia200x commented on this pull request.



>  {
+    (void) len;
+    (void) index;
     mlme_confirm_t mlme_confirm;
 
     mlme_confirm.link_req.margin = p[1];

you didn't update this. This will always read the second byte of the fopts buffer, regardless of `index`. And since we are there, maybe this should check that the size is enough and it doesn't overflow. We can return 0 to indicate there was an error and catch it in the caller.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15995#pullrequestreview-708250544
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210716/cf4ec319/attachment-0001.htm>


More information about the notifications mailing list