[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)

José Alamos notifications at github.com
Fri Jul 16 15:49:37 CEST 2021


@jia200x commented on this pull request.



> @@ -145,4 +146,13 @@ bool gnrc_lorawan_validate_dr(uint8_t dr)
     return false;
 }
 
+bool gnrc_lorawan_validate_tx_power(uint16_t tx_power)

this is not related to the NETOPTs at all. `NETOPT_TX_POWER` is technology independent. It's the task of the netif implementation to convert between `int16_t` and whatever is needed in the standard. So this should be `uint8_t`

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r671269533
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210716/0b637aa1/attachment-0001.htm>


More information about the notifications mailing list