[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)

José Alamos notifications at github.com
Fri Jul 16 16:26:19 CEST 2021


@jia200x commented on this pull request.



> +           p[last_adr_pos + 1] >> 4, p[last_adr_pos + 1] & 0x0f);
+    DEBUG("gnrc_lorawan_mlme: LinkADRReq ChMask : %u\n", (p[last_adr_pos + 3] << 8 ) \
+                                                          | p[last_adr_pos + 2]);
+    DEBUG("gnrc_lorawan_mlme: LinkADRReq Redundancy : %u\n", p[last_adr_pos + 4]);
+
+    DEBUG("gnrc_lorawan_mlme: Lastdr : %u\n",mac->last_dr); // to be removed
+    DEBUG("gnrc_lorawan_mlme: Channel Mask : %u\n",mac->channel_mask); // to be removed
+
+    mac->mlme.adr_req_recv = true;
+    return index;
+}
+
+int _fopts_mlme_link_adr_ans(lorawan_buffer_t *buf)
+{
+    if (buf) {
+        assert(buf->index + GNRC_LORAWAN_CID_SIZE <= buf->size);

```suggestion
        assert(buf->index + GNRC_LORAWAN_CID_LINK_ADR_ANS <= buf->size);
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15995#pullrequestreview-708449196
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210716/a010dabe/attachment-0001.htm>


More information about the notifications mailing list