[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)

José Alamos notifications at github.com
Fri Jul 16 18:14:29 CEST 2021

@jia200x commented on this pull request.

> @@ -107,6 +108,7 @@ void gnrc_lorawan_reset(gnrc_lorawan_t *mac)
     dev->driver->set(dev, NETOPT_RX_TIMEOUT, &rx_timeout, sizeof(rx_timeout));
+    mac->last_dr = CONFIG_LORAMAC_DEFAULT_DR;

ADR doesn't need a default value to start with. Even more, why would a function that sets the `rx2_dr` would change the last DR at all? this makes no sense to me...

You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210716/1b9449ca/attachment-0001.htm>

More information about the notifications mailing list