[riot-notifications] [RIOT-OS/RIOT] gnrc_lorawan : Add ADR support (#15995)

José Alamos notifications at github.com
Fri Jul 16 18:16:40 CEST 2021


@jia200x commented on this pull request.



> @@ -43,6 +43,9 @@ static inline void gnrc_lorawan_mlme_reset(gnrc_lorawan_t *mac)
     mac->mlme.pending_mlme_opts = 0;
     mac->rx_delay = (CONFIG_LORAMAC_DEFAULT_RX1_DELAY / MS_PER_SEC);
     mac->mlme.nid = CONFIG_LORAMAC_DEFAULT_NETID;
+    mac->mlme.adr = IS_ACTIVE(CONFIG_LORAMAC_DEFAULT_ADR) ? true : false;
+    mac->mlme.adr_ack = false;

I don't remember having such a discussion to be honest. But IMO it doesn't make sense, since this information is already included in the counter.

If you are really concerned about maintainability, you can always add `static inline` helpers (e.g `should_set_ack_bit(int adr_ack_cnt)`.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/15995#discussion_r671375125
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210716/afccc009/attachment.htm>


More information about the notifications mailing list