[riot-notifications] [RIOT-OS/RIOT] dhcpv6_client: make IA_PD an optional module (#16658)

Martine Lenders notifications at github.com
Tue Jul 20 15:22:31 CEST 2021



<!--
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
-->

### Contribution description
Prefix delegation used to be the only supported feature of our DHCPv6 client, but by now it also supports MUD, DNS recursive name servers and IA_NA is on the horizon. So it makes sense to make IA_PD an optional module like all those other features are as well.
<!--
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
-->


### Testing procedure
Binary sizes of the `tests/gnrc_dhcpv6_*` test applications as well as the border router with `USE_DHCPV6=1` should stay the same with and without this fix (build with `RIOT_CI_BUILD=1`).

When removing the line
https://github.com/miri64/RIOT/blob/233249eae0e96c36ad6d34e1806a0679d6393ced/tests/gnrc_dhcpv6_client/Makefile#L11
the build size should decrease drastically. The test will fail (since it checks for working prefix delegation), but it should not crash during the run.
<!--
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
-->


### Issues/PRs references
None.
<!--
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
-->

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/16658

-- Commit Summary --

  * dhcpv6_client: make IA_PD an optional module

-- File Changes --

    M makefiles/pseudomodules.inc.mk (1)
    M sys/net/application_layer/dhcpv6/client.c (69)
    M sys/net/gnrc/Makefile.dep (1)
    M tests/gnrc_dhcpv6_client/Makefile (1)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/16658.patch
https://github.com/RIOT-OS/RIOT/pull/16658.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16658
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210720/188bd2c1/attachment.htm>


More information about the notifications mailing list