[riot-notifications] [RIOT-OS/RIOT] netutils: add netutils_parse_hostname() (#16634)

Martine Lenders notifications at github.com
Tue Jul 20 19:40:26 CEST 2021


@miri64 approved this pull request.

Final nits. Please squash immediately.

> @@ -0,0 +1,158 @@
+/*
+ * Copyright (C) Copyright (C) 2021 ML!PA Consulting GmbH
+ *
+ * This file is subject to the terms and conditions of the GNU Lesser
+ * General Public License v2.1. See the file LICENSE in the top level
+ * directory for more details.
+ */
+
+/**
+ * @{
+ *
+ * @file
+ *
+ * @author      Benjamin Valentin <benjamin.valentin at ml-pa.com>
+* @author      Martine Lenders <mlenders at inf.fu-berlin.de>

I think I can be removed from that. Nothing in this file is particularly me. ;-).

> + * @{
+ *
+ * @file
+ * @brief       Mock implementation of sock_dns
+ *
+ * @author      Benjamin Valentin <benjamin.valentin at ml-pa.com>
+ */
+#include <string.h>
+
+#include "net/af.h"
+#include "net/ipv6/addr.h"
+#include "net/sock/dns.h"
+
+int sock_dns_query(const char *domain_name, void *addr_out, int family)
+{
+    const ipv6_addr_t a = { {

```suggestion
    static const ipv6_addr_t a = { {
```

might lead to a better stack usage, but I guess this is just premature optimization.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16634#pullrequestreview-710897542
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210720/437c70e2/attachment-0001.htm>


More information about the notifications mailing list