[riot-notifications] [RIOT-OS/RIOT] boards/lora-e5-dev: initial support (#16660)

benpicco notifications at github.com
Tue Jul 20 23:15:51 CEST 2021


@benpicco commented on this pull request.



> +ifneq (,$(filter stdio_uart,$(USEMODULE)))
+  FEATURES_REQUIRED += periph_uart
+endif

isn't that already the dependency of `stdio_uart`?

But should we have

```suggestion
ifneq (,$(filter netdev_default,$(USEMODULE)))
  USEMODULE += sx126x…
endif
```
?

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16660#pullrequestreview-711073181
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210720/37e19631/attachment-0001.htm>


More information about the notifications mailing list