[riot-notifications] [RIOT-OS/RIOT] net/gnrc_lorawan: fix random_uint32_range upper bound (#16664)

José Alamos notifications at github.com
Wed Jul 21 03:22:55 CEST 2021


<!--
The RIOT community cares a lot about code quality.
Therefore, before describing what your contribution is about, we would like
you to make sure that your modifications are compliant with the RIOT
coding conventions, see https://github.com/RIOT-OS/RIOT/wiki/Coding-conventions.
-->

### Contribution description

This PR fixes the upper bound of `random_uint32_range` during channel selection. Since this function is defined as `a <= x < b`, the current implementation picks N-1 channels (instead of N).

<!--
Put here the description of your contribution:
- describe which part(s) of RIOT is (are) involved
- if it's a bug fix, describe the bug that it solves and how it is solved
- you can also give more information to reviewers about how to test your changes
-->


### Testing procedure

Join a NS with ABP using `examples/gnrc_lorawan`. Send many unconfirmable uplinks. Make sure 3 channels are used.
@akshaim, coud you give it a look, since you have all the hardware?
<!--
Details steps to test your contribution:
- which test/example to compile for which board and is there a 'test' command
- how to know that it was not working/available in master
- the expected success test output
-->


### Issues/PRs references

Discovered while reading the SDR results in https://github.com/RIOT-OS/RIOT/pull/15946#issuecomment-883370407
<!--
Examples: Fixes #1234. See also #5678. Depends on PR #9876.

Please use keywords (e.g., fixes, resolve) with the links to the issues you
resolved, this way they will be automatically closed when your pull request
is merged. See https://help.github.com/articles/closing-issues-using-keywords/.
-->

You can view, comment on, or merge this pull request online at:

  https://github.com/RIOT-OS/RIOT/pull/16664

-- Commit Summary --

  * net/gnrc_lorawan: fix random_uint32_range upper bound

-- File Changes --

    M sys/net/gnrc/link_layer/lorawan/gnrc_lorawan_region.c (2)

-- Patch Links --

https://github.com/RIOT-OS/RIOT/pull/16664.patch
https://github.com/RIOT-OS/RIOT/pull/16664.diff

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16664
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210720/984a8671/attachment.htm>


More information about the notifications mailing list