[riot-notifications] [RIOT-OS/RIOT] dhcpv6_client: refactor to use `event_timeout` for non-sock timeouts (#16668)

Karl Fessel notifications at github.com
Wed Jul 21 14:25:15 CEST 2021


@kfessel commented on this pull request.

some time unit typos

> @@ -208,7 +206,20 @@ static inline bool _is_tid(dhcpv6_msg_t *msg)
 
 static inline uint32_t _now_cs(void)
 {
+#if IS_USED(MODULE_ZTIMER)
+    return (uint32_t)(ztimer_now(ZTIMER_MSEC) / US_PER_CS);

reads like this should use `MS_PER_CS`
```suggestion
    return (uint32_t)(ztimer_now(ZTIMER_MSEC) / MS_PER_CS);
```

>      return (uint32_t)(xtimer_now_usec64() / US_PER_CS);
+#endif
+}
+
+static inline uint32_t _now_sec(void)
+{
+#if IS_USED(MODULE_ZTIMER)
+    return (uint32_t)ztimer_now(ZTIMER_MSEC);

needs a factor of 1/1000?
```suggestion
    return (uint32_t)(ztimer_now(ZTIMER_MSEC) / MS_PER_SEC));
```

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16668#pullrequestreview-711584712
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210721/004c8d66/attachment.htm>


More information about the notifications mailing list