[riot-notifications] [RIOT-OS/RIOT] sock_dns: factor out message parsing and composition (#16669)

Martine Lenders notifications at github.com
Wed Jul 21 15:09:55 CEST 2021


@miri64 commented on this pull request.



> @@ -7,31 +7,24 @@
  */

Just to avoid confusion in the review: I did not rename the file and then moved the `sock_dns` parts to `sys/net/application_layer/dns/dns.c`, rather I renamed `sys/net/application_layer/dns/dns.c` to `sys/net/application_layer/sock_dns/dns.c` and then moved the message composition and parsing parts from `sys/net/application_layer/sock_dns/dns.c` to this `sys/net/application_layer/dns/msg.c`. However, since that was the majority of `sys/net/application_layer/sock_dns/dns.c`'s content, Git interpreted it as a rename.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16669#pullrequestreview-711633496
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210721/5ee2b9ad/attachment.htm>


More information about the notifications mailing list