[riot-notifications] [RIOT-OS/RIOT] dhcpv6_client: refactor to use `event_timeout` for non-sock timeouts (#16668)

Martine Lenders notifications at github.com
Fri Jul 23 10:02:09 CEST 2021


@miri64 commented on this pull request.



> +#if IS_USED(MODULE_EVENT_TIMEOUT_ZTIMER)
+    event_timeout_ztimer_init(timeout, ZTIMER_SEC, event_queue, event);
+    event_timeout_set(timeout, delay_sec);
+#else
+    event_timeout_init(timeout, event_queue, event);
+    /* use xtimer_set64 instead of event_timeout_set to prevent overflows */
+    xtimer_set64(&timeout->timer, ((uint64_t)delay_sec) * US_PER_SEC);
+#endif

Sure, but nothing prevents us to port that to `ZTIMER_SEC` in the future as well ;-). Currently the same problem exists in master, since the `xtimer` of DHCPv6 uses 64-bit scale.

-- 
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/RIOT-OS/RIOT/pull/16668#discussion_r675376580
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.riot-os.org/pipermail/notifications/attachments/20210723/9303c441/attachment.htm>


More information about the notifications mailing list